Skip to content

Naming Consistencies#21126

Open
g0tmi1k wants to merge 3 commits intorapid7:masterfrom
g0tmi1k:naming
Open

Naming Consistencies#21126
g0tmi1k wants to merge 3 commits intorapid7:masterfrom
g0tmi1k:naming

Conversation

@g0tmi1k
Copy link
Contributor

@g0tmi1k g0tmi1k commented Mar 16, 2026

DHClient

There is a lot more using env rather than environment for module names.
Plus there is already a auxiliary that does mostly the same (just doesn't use /etc/crontab):

$ find modules -name '*environment*.rb' | wc -l
       2
$ find modules -name '*env*.rb' | wc -l
      30
$
$ find . -name 'dhclient*'
./modules/auxiliary/server/dhclient_bash_env.rb
$

PXE

Making sure their names match as they are mostly the same with:

  • exploits/windows/local/pxe_exploit
  • auxiliary/server/pxe_exploit

At the same time, rather than it all being a single word, separating them out with _

Shellshock

  • Variable Injection -> Variable Code Injection
  • Making sure (Shellshock) (aka the codename) is at the end

@adfoster-r7
Copy link
Contributor

As a note to the reviewer; when renaming modules we'll to add a pointer from the old name:

moved_from 'exploit/multi/http/coldfusion_rds'

And we'll want to verify none of these modules are very popular, as it can be confusing to users or break old guides when they change; similarly confirm that Metasploit Pro doesn't directly invoke these modules behind the scenes as that can also break things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants